View | Annotate | Download (6.7 KB)
imaplibutil: Remove flagrantly bad use of private attribute
Frankly, the original code doesn't even make much sense, and moreover it's not forward compatible with python 2.6, and furthermore:
DeprecationWarning: socket.ssl() is deprecated.
So, this commit is just a temporary fix.
Signed-off-by: Michael Witten <mfwitten@mit.edu>
Fix performance for SSL
Added WrappedIMAP4_SSL class to help fix up performance of SSL
Standard imaplib.py is really bad with this, since it reads one character at a time.
Reported by Aaron Kaplan at offlineimap@complete.org/2008/01/msg00012.html.gz">http://lists.complete.org/offlineimap@complete.org/2008/01/msg00012.html.gz
He wrote:
I just noticed that the version of offlineimap I've been using (3.99.17) is well over four years old. How time flies. I haven't had any problems with it, but out of curiosity I decided to pull in 5.99.2 from the fedora repository. It turns out to take consistently over twice as long as the old version to sync the same account. Is this expected?
He tracked it down at offlineimap@complete.org/2008/02/msg00012.html.gz">http://lists.complete.org/offlineimap@complete.org/2008/02/msg00012.html.gz
The following changeset is the one responsible for the difference in speed I was noticing between the imaplib.py that was packaged with older versions of offlineimap and the one that comes with python:
Fix non-SSL connection
fixes deb#432727
Compilation fixes
Clean up imaplib imports
Merging imaplibutil into code
Start of work pulling code out of imaplib.py
Configurable thread status character for ui.Curses.Blinkenlights